Merged
Conversation
Updated: 1. root with api folder and added FPP.md (flow preprocessing) 2. _config.yml was updated with sphinx extensions 3. _toc.yml was updated with api chapter
made minor syntax corrections
1. Files under HydroGenerate folder have modified docstrings so that they are sphinx compatible. Main code has not been modified. 2. The doc folder is updated with the new api folder, which has sphinx compatible markdowns for each module.
…bResearch/HydroGenerate into Docstrings_documentation
Somehow this file did not go through the last time
1. reviewer comment on icc was because of syntax of the key "newstream-reach" which has been corrected. 2. All books have been compiled without errors 3. All images have been compiled 4. error due to max_flow_checker has been resolved
1. python version in setup.py has been changed from 3.8 to 3.10 2. removed https from dois 3. changed citation for readme including Soumyadeep Nag and removing version 3.6 from title
Collaborator
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made:
Added Bhaskar Mitra and his ORCID ID
python version in setup.py has been changed from 3.8 to 3.10
removed https from dois
changed citation for readme including Soumyadeep Nag and removing version 3.6 from title